add support for Sensitive type in Environment#98
add support for Sensitive type in Environment#98gmenuel wants to merge 1 commit intovoxpupuli:masterfrom
Conversation
|
Isn't #94 the correct thing to do here really. |
|
Yes using podman secret is probably cleaner, this is just easier to use, and since it was really not complicated to implement I thought it could be useful (it is at least for me 🙂) |
|
[like] Steve Traylen reacted to your message:
…________________________________
From: Gregoire Menuel ***@***.***>
Sent: Tuesday, February 17, 2026 2:22:12 PM
To: voxpupuli/puppet-quadlets ***@***.***>
Cc: Steve Traylen ***@***.***>; Comment ***@***.***>
Subject: Re: [voxpupuli/puppet-quadlets] add support for Sensitive type in Environment (PR #98)
[https://avatars.githubusercontent.com/u/22345278?s=20&v=4]gmenuel left a comment (voxpupuli/puppet-quadlets#98)<#98 (comment)>
Yes using podman secret is probably cleaner, this is just easier to use, and since it was really not complicated to implement I thought it could be useful (it is at least for me 🙂)
—
Reply to this email directly, view it on GitHub<#98 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABBAJIKXVKI4VCEKL6RKU34MMPZJAVCNFSM6AAAAACVM3PHQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJUHE3TMMZVHA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Hi, Could you add a new acceptance test case for this. Just to confirm nothing blows up later in the templates or something. Otherwise fine. |
|
I've added an acceptance spec, I'm not 100% sure that I've done everything that is needed to have the test run, don't hesitate if something is missing or wrong. |
|
The unrelated test failure is now fixed if you want to take another look. |
2 participants
Pull Request (PR) description
Sometimes it is useful to set an environment variable containing sensitive information. This PR add the support for the Sensitive type in the Environment field of the container block.
This Pull Request (PR) fixes the following issues
n/a